Skip to content

command: add dvc push instruction after dvc repro #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2020
Merged

command: add dvc push instruction after dvc repro #4737

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77a038e
command: add dvc push instruction after dvc repro
jvfe Oct 17, 2020
53b6499
command: change dvc push instruction for dvc repro
jvfe Oct 26, 2020
a3ba96d
command: Use backticks and else in dvc repro log
jvfe Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dvc/command/repro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ def run(self):

if len(stages) == 0:
logger.info(CmdDataStatus.UP_TO_DATE_MSG)
else:
logger.info(
"Use `dvc push` to send your updates to "
"remote storage."
Comment on lines +35 to +36
Copy link
Contributor

@jorgeorpinel jorgeorpinel Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Should we update some of the console examples in https://dvc.org/doc/command-reference/repro? Several show the command's output.

p.s. looks like that could fit in a single-line-string in the code?

Copy link
Contributor

@pared pared Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good point, but there is a problem:
In the example, in repro we modify code only, without influence on the output of the stage...
Seems to me like we should not display this help message there. So I would say we should not update the command reference but fix the underlying issue.

)

if self.args.metrics:
metrics = self.repo.metrics.show()
Expand Down