Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Apr 20, 2021

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Will close #5641

@pmrowla pmrowla added the bugfix fixes bug label Apr 20, 2021
@pmrowla pmrowla self-assigned this Apr 20, 2021
@pmrowla
Copy link
Contributor Author

pmrowla commented Apr 20, 2021

@werthen @FredericoCoelhoNunes can you try installing from this PR to see if it resolves your issue w/dvc exp run --temp or --queue+--run-all on NFS mounts

It can be installed via pip with:

pip install git+https://github.com/iterative/dvc.git@refs/pull/5849/head

@FredericoCoelhoNunes
Copy link

Hi @pmrowla , it did indeed seem to fix the problem for me! Fantastic work.
dvc exp show fails with ERROR: unexpected error - 'NoneType' object is not subscriptable immediately afterwards dvc exp run --run-all, but I think that's addressed here: #3434 (doesn't appear to be related with the issue at hand, but I thought it would be worth mentioning just in case).

@werthen
Copy link

werthen commented Apr 22, 2021

I will also test this tomorrow, have had little time to do so.

@efiop
Copy link
Contributor

efiop commented Apr 29, 2021

@pmrowla What's the status on this one?

@pmrowla
Copy link
Contributor Author

pmrowla commented Apr 30, 2021

@pmrowla What's the status on this one?

@efiop

Was waiting on @werthen's test since they filed the original review, but given that we've had several other people confirm the fix works in discord I think we can merge this

@pmrowla pmrowla changed the title [WIP] pygit: force release of odb contexts after checkout/merge pygit: force release of odb contexts after checkout/merge Apr 30, 2021
@pmrowla pmrowla marked this pull request as ready for review April 30, 2021 01:18
@pmrowla pmrowla merged commit 753803c into treeverse:master Apr 30, 2021
@pmrowla pmrowla deleted the 5641-pygit-nfs branch April 30, 2021 05:16
@werthen
Copy link

werthen commented Apr 30, 2021

For what it's worth, I also performed a test and it seems to be working as intended now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix fixes bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exp run: cannot clean up temp directory runs on Linux + NFS

4 participants