Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions dvc/fs/ssh.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import os.path
import threading

from funcy import cached_property, first, memoize, silent, wrap_prop, wrap_with
from funcy import cached_property, memoize, silent, wrap_prop, wrap_with

from dvc import prompt
from dvc.scheme import Schemes
Expand Down Expand Up @@ -68,14 +68,17 @@ def _prepare_credentials(self, **config):

login_info["password"] = config.get("password")

if user_ssh_config.get("IdentityFile"):
config.setdefault(
"keyfile", first(user_ssh_config.get("IdentityFile"))
)
raw_keys = []
if config.get("keyfile"):
raw_keys.append(config.get("keyfile"))
elif user_ssh_config.get("IdentityFile"):
raw_keys.extend(user_ssh_config.get("IdentityFile"))

if raw_keys:
login_info["client_keys"] = [
os.path.expanduser(key) for key in raw_keys
]

keyfile = config.get("keyfile")
if keyfile:
login_info["client_keys"] = [os.path.expanduser(keyfile)]
login_info["timeout"] = config.get("timeout", _SSH_TIMEOUT)

# These two settings fine tune the asyncssh to use the
Expand Down
18 changes: 18 additions & 0 deletions tests/unit/fs/test_ssh.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,24 @@ def test_ssh_keyfile(mock_file, config, expected_keyfile):
assert fs.fs_args.get("client_keys") == expected_keyfile


mock_ssh_multi_key_config = """
IdentityFile file_1

Host example.com
IdentityFile file_2
"""


@patch(
"builtins.open",
new_callable=mock_open,
read_data=mock_ssh_multi_key_config,
)
def test_ssh_multi_identity_files(mock_file):
fs = SSHFileSystem(host="example.com")
assert fs.fs_args.get("client_keys") == ["file_1", "file_2"]


@pytest.mark.parametrize(
"config,expected_gss_auth",
[
Expand Down