build(deps): Bump pylint from 2.9.6 to 2.11.1 #6636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
force-pushed
the
dependabot/pip/pylint-2.11.1
branch
from
c0cc2de to
2a22aa3
Compare
Contributor
Author
|
Looks like pylint is no longer a dependency, so this is no longer needed. |
Collaborator
|
@dependabot reopen |
dependabot
bot
force-pushed
the
dependabot/pip/pylint-2.11.1
branch
3 times, most recently
from
c6ca56c to
0e4a0f6
Compare
dependabot
bot
force-pushed
the
dependabot/pip/pylint-2.11.1
branch
from
0e4a0f6 to
ebdc168
Compare
Contributor
|
@Mergifyio rebase |
Bumps [pylint](https://github.com/PyCQA/pylint) from 2.9.6 to 2.11.1. - [Release notes](https://github.com/PyCQA/pylint/releases) - [Changelog](https://github.com/PyCQA/pylint/blob/main/ChangeLog) - [Commits](pylint-dev/pylint@v2.9.6...v2.11.1) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
✅ Branch has been successfully rebased |
skshetry
force-pushed
the
dependabot/pip/pylint-2.11.1
branch
from
46b74e6 to
16c0c43
Compare
Collaborator
|
@karajan1001, for some of the files, we may want to use locale encoding instead of utf-8. |
skshetry
reviewed
Oct 19, 2021
| config, backend = self.get_config_and_backend(name) | ||
| if "startup_script" in config: | ||
| with open(config["startup_script"]) as fobj: | ||
| with open(config["startup_script"], encoding="utf-8") as fobj: |
Collaborator
There was a problem hiding this comment.
We should probably use locale encoding here.
Contributor
There was a problem hiding this comment.
UTF-8 is correct, any of these TPI configuration fields (including the startup script) are expected to be UTF-8 text, this is consistent with terraform configuration in general
skshetry
reviewed
Oct 19, 2021
skshetry
reviewed
Oct 19, 2021
skshetry
approved these changes
Oct 19, 2021
pared
approved these changes
Oct 19, 2021
Contributor
|
@karajan1001 What about #6636 (comment) , btw? Sorry for not using "Request changes" and introducing confusion. |
karajan1001
added a commit
that referenced
this pull request
Oct 20, 2021
This reverts commit 4646208.
efiop
pushed a commit
that referenced
this pull request
Oct 20, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps pylint from 2.9.6 to 2.11.1.
Changelog
Sourced from pylint's changelog.
... (truncated)
Commits
d98e6e8Bump pylint to 2.11.1, update changelog6d07d6fAdd typing forjson_reporterand sub-classesf45ab49Fixunspecified-encodingforPath()67957e2Move back to a dev version following 2.11.0 release7add5d0Bump pylint to 2.11.0, update changelog0d246e5Add typing tofilepath(#4980)dc0c7e9Add typing inpylint.reporters(#5004)14f4db5Move methods toBaseLayout(#5015)d4e61b9Move PyreverseConfig to pylint.testutil (#5013)22e56c0Add typing to all calls toself.stats(#4973)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)