plots: revert templates in packages change

[pared]

Fixes: #6911
Reverts: a1b1466

• ❗ I have followed the Contributing to DVC checklist.

• 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

In #6550 we introduced templates in packages. While utilizing importlib.resources and including templates with our package makes sense for other types of builds, in the case of our binary packages and pyinstaller we cannot include package data, because of pyinstaller/pyinstaller#2697.

What we could do with pyinstaller would be to create resources directory alongside dvc and include the templates there. That would require us to load our templates differently depending on whether we can load data from package (other builds) or pyinstallers sys._MEIPASS when using binary packages.

This seems much more error-prone than the previous approach (keeping predefined templates as python dicts in dvc/repo/plots/template.py and is harder to test (it would require us to test binary packages).

That is why I decided to revert the change about templates in packages.

cc @dberenbaum

[pmrowla]

@pared What was the issue with adding data files in pyinstaller (it looks like you might have linked the wrong issue)? Is there a reason we can't do something like they've documented here: https://pyinstaller.readthedocs.io/en/stable/spec-files.html#adding-files-to-the-bundle

[pared]

@pmrowla

The issue I attached is regarding the package level files - for mac and Linux we will be unable to pack the templates, simply because pyinstaller creates executable of dvc name and tries to create dvc/.../templates right after.

We could try adding the files to the bundle but that would mean that we need to use separate logic for loading templates when using a non-binary package and a different one when using binary one, which seems to me to be more error prone and would require us to test binary packages.

[pared]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[pared]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[efiop]

@pared What's the status here?

[pared]

Awaiting review