exp list: add the new flags (including -A/--all-commits) (#7153) #7245

karajan1001 · 2022-01-10T08:26:18Z

fix: #7153
Unify the flags in exp list to exp show (including -A/--all-commits
)
Wait #7152 and #7206

Add new -A,-n flags to exp list command.
Add unit test for the flag parse.
unify the revs retrive logic to exp show.
Add functional test for exp list

❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

tests/func/experiments/test_remote.py

pmrowla

This will need a docs PR.

@karajan1001 it would also be helpful to put together an asciinema demo of the new flags (it would be fine to have one demo containing all of the different commands instead of a separate demo for each of these PRs)

Related to treeverse/dvc#7245

dvc/commands/experiments/__init__.py

jorgeorpinel · 2022-02-16T05:48:17Z

dvc/commands/experiments/__init__.py

Also, I have a question: what happens when --rev (or an included parent) is a merge? Which <num> ancestors are included?

@jorgeorpinel

It will include the first parent for merge commits (linear ancestors, equivalent to using tilde ~ in git). We don't support specifying a different parent (i.e carat ^ in git).

So for --rev HEAD -n 2 You would get the commit referenced by HEAD~2 in git (as opposed to HEAD~2^2/HEAD~2^3...

see: https://stackoverflow.com/a/43046393/1538451

Got it, thanks @pmrowla ! I wonder if we want to include this info. in the description or in docs. May be relevant if people use large -n values (likely to include merges) cc @karajan1001 .

Related to treeverse/dvc#7245

dberenbaum · 2022-02-23T17:25:10Z

@karajan1001 What's the status of this one? Seems like this one needs to be merged before moving forward with the related core and docs PRs.

karajan1001 · 2022-02-24T07:22:58Z

@jorgeorpinel, Need some final check and approval. the other two one #7275, #7255 all depend on it.

dberenbaum · 2022-03-01T22:34:46Z

@karajan1001 I still see that -n -1 fails, as mentioned in #7204 (comment). I also thought that change was going to be rolled back, but I don't see any rollback. What's the status?

karajan1001 · 2022-03-03T08:12:43Z

@karajan1001 I still see that -n -1 fails, as mentioned in #7204 (comment). I also thought that change was going to be rolled back, but I don't see any rollback. What's the status?

need to release a new version.
treeverse/scmrepo#36

dvc/commands/experiments/__init__.py

jorgeorpinel

Output strings look good, thanks.

fix: treeverse#7153 Unify the flags in `exp list` to `exp show` 1. Add new `-A`, `-n` flags to `exp list` command. 2. Add unit test for the flag parse. 3. unify the revs retrive logic to `exp show`. 4. Add functional test for `exp list` 5. Update the documents. Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>

) * add a new `num` arg to exp list, rename `--all` to `--all-commits` Related to treeverse/dvc#7245 * Some updates * Update content/docs/command-reference/exp/list.md Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> * Restyled by prettier Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>

karajan1001 requested a review from a team as a code owner January 10, 2022 08:26

karajan1001 requested a review from pared January 10, 2022 08:26

karajan1001 marked this pull request as draft January 10, 2022 08:26

karajan1001 requested review from pmrowla and removed request for pared January 10, 2022 08:26

karajan1001 force-pushed the fix7153 branch 3 times, most recently from 4996a9c to ce68fea Compare January 11, 2022 11:44

This was referenced Jan 11, 2022

exp push/pull: make all the flags in exp show and exp list support pull/push (#7154) #7255

Merged

exp show: add --rev flag (#7152) #7204

Merged

karajan1001 added A: experiments Related to dvc exp enhancement Enhances DVC labels Jan 11, 2022

karajan1001 marked this pull request as ready for review January 11, 2022 14:24

karajan1001 changed the title ~~[WIP] exp list: add the new flags (including -A/--all-commits , -a/--all-branches, --all-tags) (#7153)~~ exp list: add the new flags (including -A/--all-commits , -a/--all-branches, --all-tags) (#7153) Jan 11, 2022

karajan1001 force-pushed the fix7153 branch from ce68fea to dfdc322 Compare January 12, 2022 03:07

karajan1001 commented Jan 12, 2022

View reviewed changes

tests/func/experiments/test_remote.py Outdated Show resolved Hide resolved

karajan1001 force-pushed the fix7153 branch 2 times, most recently from 3f93209 to 4ccc0ce Compare January 14, 2022 10:35

karajan1001 changed the title ~~exp list: add the new flags (including -A/--all-commits , -a/--all-branches, --all-tags) (#7153)~~ exp list: add the new flags (including -A/--all-commits) (#7153) Jan 14, 2022

karajan1001 force-pushed the fix7153 branch 3 times, most recently from 9c5b39e to 338b4e6 Compare January 17, 2022 04:00

pmrowla previously approved these changes Jan 17, 2022

View reviewed changes

karajan1001 mentioned this pull request Jan 17, 2022

exp remove: rename --all-commits flag add a new rev flag and unify the collection of revs (#7155) #7275

Merged

2 tasks

karajan1001 added a commit to karajan1001/dvc.org that referenced this pull request Jan 17, 2022

add a new num arg to exp list, rename --all to --all-commits

952bd69

Related to treeverse/dvc#7245

karajan1001 added a commit to karajan1001/dvc.org that referenced this pull request Jan 18, 2022

add a new num arg to exp list, rename --all to --all-commits

f5e1e15

Related to treeverse/dvc#7245

karajan1001 dismissed pmrowla’s stale review via 9866dda January 18, 2022 07:24

karajan1001 mentioned this pull request Jan 18, 2022

exp list: add --num option, rename --all to --all-commits treeverse/dvc.org#3191

Merged

karajan1001 requested review from jorgeorpinel and skshetry January 18, 2022 07:24

jorgeorpinel mentioned this pull request Jan 27, 2022

exp show: add --rev option treeverse/dvc.org#3187

Merged

skshetry removed their request for review January 27, 2022 03:51

This was referenced Jan 27, 2022

exp push/pull: add --rev, -n, -A flags treeverse/dvc.org#3192

Merged

exp remove: add --rev and -n options treeverse/dvc.org#3193

Merged

jorgeorpinel reviewed Jan 27, 2022

View reviewed changes

dvc/commands/experiments/__init__.py Outdated Show resolved Hide resolved

karajan1001 force-pushed the fix7153 branch from 7eedbdd to 1c6939a Compare January 27, 2022 11:54

jorgeorpinel reviewed Feb 2, 2022

View reviewed changes

dvc/commands/experiments/__init__.py Outdated Show resolved Hide resolved

karajan1001 force-pushed the fix7153 branch 3 times, most recently from 9e1a4f1 to 20ef402 Compare February 10, 2022 08:54

jorgeorpinel mentioned this pull request Feb 16, 2022

exp show/list --num: rename metavar from <num> to <int> #7314

Closed

jorgeorpinel reviewed Feb 16, 2022

View reviewed changes

karajan1001 added a commit to karajan1001/dvc.org that referenced this pull request Feb 16, 2022

add a new num arg to exp list, rename --all to --all-commits

f79c966

Related to treeverse/dvc#7245

karajan1001 requested a review from jorgeorpinel February 21, 2022 06:27

karajan1001 force-pushed the fix7153 branch from 20ef402 to f14dbdd Compare February 24, 2022 07:27

skshetry mentioned this pull request Mar 7, 2022

Revert #24 and #25 treeverse/scmrepo#39

Merged

jorgeorpinel reviewed Mar 8, 2022

View reviewed changes

dvc/commands/experiments/__init__.py Outdated Show resolved Hide resolved

jorgeorpinel approved these changes Mar 8, 2022

View reviewed changes

pmrowla approved these changes Mar 8, 2022

View reviewed changes

karajan1001 force-pushed the fix7153 branch from 0b3ea70 to 0be8c85 Compare March 8, 2022 07:52

karajan1001 enabled auto-merge (rebase) March 8, 2022 07:52

karajan1001 merged commit d033345 into treeverse:main Mar 8, 2022

karajan1001 deleted the fix7153 branch March 8, 2022 08:18

exp list: add the new flags (including -A/--all-commits) (#7153) #7245

exp list: add the new flags (including -A/--all-commits) (#7153) #7245

Uh oh!

Conversation

karajan1001 commented Jan 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pmrowla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

jorgeorpinel Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmrowla Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dberenbaum commented Feb 23, 2022

Uh oh!

karajan1001 commented Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dberenbaum commented Mar 1, 2022

Uh oh!

karajan1001 commented Mar 3, 2022

Uh oh!

Uh oh!

jorgeorpinel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

karajan1001 commented Jan 10, 2022 •

edited

Loading

jorgeorpinel Feb 16, 2022 •

edited

Loading

pmrowla Feb 16, 2022 •

edited

Loading

jorgeorpinel Feb 16, 2022 •

edited

Loading

karajan1001 commented Feb 24, 2022 •

edited

Loading

jorgeorpinel left a comment •

edited

Loading