-
Notifications
You must be signed in to change notification settings - Fork 1.3k
exp push/pull: make all the flags in exp show and exp list support pull/push (#7154) #7255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5bd915c to
71a4235
Compare
9e58374 to
b4efc61
Compare
e311ded to
25aa390
Compare
|
Nice work @karajan1001! I have a few questions:
We should recognize that no experiments have actually been pushed and make the output something like
|
In my opinion, For
Yeah.
Yes, it works, |
👍
👍
It works for me in |
Excuse me, Are you in the latest version? I had already removed the default |
|
Sorry, must have been behind. Looks good now! One last thing: Should |
This error comes from |
Can the default be |
I had tried several cases on my computer. It works fine for me. |
a9ec406 to
9d0cced
Compare
related to treeverse/dvc#7255 Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
jorgeorpinel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI strings LGTM 👍🏼
…evs (treeverse#7154) fix: treeverse#7154 1. rename flags `-A/--all-commits` in the `exp pull/push` 2. add new flag "--rev" and "--num" in the `exp pull/push` 3. Unify the collection of revs in `exp push/pull` 4. add unit and func tests for `exp push/pull`
* exp show: add `--rev`, `-n`, `-A` flag exp pull/push related to treeverse/dvc#7255 Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> * some updates * Update content/docs/command-reference/exp/push.md Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> * Update content/docs/command-reference/exp/pull.md Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> * Restyled by prettier * Update content/docs/command-reference/exp/pull.md Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> * Update content/docs/command-reference/exp/push.md Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
…ll/push (#7154) Original PR #7255 by karajan1001 Original: treeverse/dvc#7255
…and exp list support pull/push (#7154) Merged from original PR #7255 Original: treeverse/dvc#7255
wait for #7245
exp push/pull: make all the flags in exp show and exp list support pull/push (#7154)
fix: #7154
exp showto theexp pull/pushexp push/pull❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏