From 610cc99003cdef42045f16da4edb1047c74b94da Mon Sep 17 00:00:00 2001 From: karajan1001 Date: Mon, 8 Aug 2022 20:53:49 +0800 Subject: [PATCH 1/2] Add flaky to a queue related test. This is a flaky, the queue tasks status might remain "Running" even if it had already been completed, beside sometimes I also noticed it raise a pytest fixture error. --- tests/func/experiments/test_queue.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/func/experiments/test_queue.py b/tests/func/experiments/test_queue.py index 92259c31bb..3618ccfe39 100644 --- a/tests/func/experiments/test_queue.py +++ b/tests/func/experiments/test_queue.py @@ -64,6 +64,7 @@ def test_celery_logs( assert "failed to reproduce 'failed-copy-file'" in captured.out +@pytest.mark.flaky(rerun=3) def test_queue_remove_done(dvc, failed_tasks, success_tasks): assert len(dvc.experiments.celery_queue.failed_stash) == 3 status = to_dict(dvc.experiments.celery_queue.status()) From 90f79b741c12fadb751a115390eaa87efcb73eeb Mon Sep 17 00:00:00 2001 From: skshetry Date: Mon, 8 Aug 2022 19:16:37 +0545 Subject: [PATCH 2/2] Update tests/func/experiments/test_queue.py --- tests/func/experiments/test_queue.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/func/experiments/test_queue.py b/tests/func/experiments/test_queue.py index 3618ccfe39..6802da0c73 100644 --- a/tests/func/experiments/test_queue.py +++ b/tests/func/experiments/test_queue.py @@ -64,7 +64,7 @@ def test_celery_logs( assert "failed to reproduce 'failed-copy-file'" in captured.out -@pytest.mark.flaky(rerun=3) +@pytest.mark.flaky(max_runs=3, min_passes=1) def test_queue_remove_done(dvc, failed_tasks, success_tasks): assert len(dvc.experiments.celery_queue.failed_stash) == 3 status = to_dict(dvc.experiments.celery_queue.status())