Skip to content

exp run: ui tweak #8124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

exp run: ui tweak #8124

merged 1 commit into from
Aug 11, 2022

Conversation

@dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Aug 10, 2022

Part of #8116:

  • UI / Terminology - I got completely confused with Reproduced experiment. I thought this is about run cache, or some existing experiments, etc. Why do we use reproduced for a completely new experiment, for example? And when it actually doesn't create a new experiment (since probably detects an existing one) it doesn't say anything at all. cc @dberenbaum

@dberenbaum dberenbaum requested a review from a team as a code owner August 10, 2022 14:37
@dberenbaum dberenbaum requested a review from dtrifiro August 10, 2022 14:37
@dberenbaum
Copy link
Contributor Author

dberenbaum commented Aug 10, 2022

I didn't want to say "completed" or anything similar since it could be misleading for checkpoints.

@dberenbaum dberenbaum requested a review from shcheklein August 10, 2022 14:38
@daavoo daavoo enabled auto-merge (rebase) August 10, 2022 17:32
@skshetry skshetry disabled auto-merge August 11, 2022 03:29
@skshetry skshetry closed this Aug 11, 2022
@skshetry skshetry reopened this Aug 11, 2022
@skshetry skshetry merged commit 9837747 into main Aug 11, 2022
@skshetry skshetry deleted the exp-run-msg branch August 11, 2022 03:29
@pmrowla pmrowla added A: experiments Related to dvc exp maintenance labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtrifiro dtrifiro Awaiting requested review from dtrifiro dtrifiro was automatically assigned from iterative/dvc

1 more reviewer

@shcheklein shcheklein shcheklein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A: experiments Related to dvc exp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dberenbaum @shcheklein @pmrowla @skshetry