Skip to content

Conversation

@blakeNaccarato
Copy link
Contributor

@blakeNaccarato blakeNaccarato commented Nov 9, 2022

Add SVG to parser and parametrize an existing functionality test on SVG as well as JPG.

If needed I can also modify a test in tests/integration/plots to check SVG functionality. I haven't done that yet as it would touch quite a few lines.

Fixes #6714.

^ Regarding the documentation check above, I will add SVG to the list under plots over in the documentation as needed.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 94.30% // Head: 94.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (560be12) compared to base (a6bfc7d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8542   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         429      429           
  Lines       32822    32825    +3     
  Branches     4591     4592    +1     
=======================================
+ Hits        30954    30957    +3     
  Misses       1450     1450           
  Partials      418      418           
Impacted Files Coverage Δ
tests/func/plots/test_show.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry requested a review from pared November 9, 2022 06:06
@pared
Copy link
Contributor

pared commented Nov 9, 2022

Image files are pasted into <img> section, so I think we don't necessarily need a specific integration test for that.

Add SVG to parser and parametrize an existing functionality test on SVG as well as JPG.

Fixes treeverse#6714.
@efiop efiop force-pushed the expand-supported-images-extensions branch from e3d164f to 560be12 Compare November 9, 2022 17:04
@efiop efiop enabled auto-merge (rebase) November 9, 2022 17:08
@efiop efiop merged commit 49af6e1 into treeverse:main Nov 9, 2022
@blakeNaccarato
Copy link
Contributor Author

blakeNaccarato commented Nov 9, 2022

Thanks! I've opened an issue (treeverse/dvc.org#4109) over at https://github.com/iterative/dvc.org to track my related documentation.

I hope that the broken CI after merging to main is due to it just being the first merge after the PR that added the all-OS Python 3.11 tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: plots Related to the plots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plots: expand supported images extensions

4 participants