Add integration tests for Azure Remote#875
Merged
efiop merged 10 commits intotreeverse:masterfrom Jul 11, 2018
CatalystCode:azure-integration-tests
Merged
Add integration tests for Azure Remote#875efiop merged 10 commits intotreeverse:masterfrom CatalystCode:azure-integration-tests
efiop merged 10 commits intotreeverse:masterfrom
CatalystCode:azure-integration-tests
Conversation
It is generally recommended to use the subprocess module instead of the os module to run subshell commands given since the former makes it easier to comunicate with the process, has an improved security model, etc. More information is available in [1]. Note that this change uses `check_output` instead of `check_call` to prevent the command output from being printed to stdout. This change also introduces two additional enhancements: - Skip the hadoop test if the hadoop binary is not available. - Skip the ssh test if the ssh binary is not available. [1] https://docs.python.org/3/library/subprocess.html#replacing-os-system
Note: the tests are run against the Azurite [1] local emulator for Azure Blob Storage and not against a live service. [1] https://github.com/azure/azurite
This helps verify in the CI that the environment variables for the integration tests are set up correctly since we can see exactly which tests are being executed and which ones are being skipped.
Contributor
|
Hi @c-w ! Thank you for the follow up! Looks great! I see that our appveyor test is failing on Azure test, is there any chance you could also setup azurite for it? Thanks, |
Contributor
Author
|
Working on it. Might be pushing a bunch of odd updates to the PR to re-trigger the build while I figure this out. Will ping you when this is ready to be reviewed again. |
Contributor
Author
|
Hi @efiop. Happy to report that the AppVeyor build now runs the Azure remote integration tests via Azurite. I tried three approaches to set this up:
|
Contributor
|
Hi @c-w ! Thank you so much for the amazing work! Merged! I will release 0.11.0 with Azure support until tomorrow. |
Contributor
Author
|
Thanks for the merge! Looking forward to the package being released :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #868.
The main change of this pull request is to set up the Azure Storage emulator Azurite on the Travis CI machine via Docker and runs the Azure integration tests against the emulator (fcd0e34). An example of a successful build with this configuration on Travis can be found here.
The pull request also contains a number of related functional fixes:
Additionally, the pull request also includes some related refactoring:
os.systemand make should-run cloud test checks more robust (9724bd9).