Skip to content

Conversation

@daavoo
Copy link
Contributor

@daavoo daavoo commented Dec 12, 2022

Only log warnings about Studio if studio_token is set. Only log warnings about DVC Repo if save_dvc_exp is True.

Only log warnings about Studio if `studio_token` is set.
Only log warnings about DVC Repo if `save_dvc_exp` is True.
@codecov-commenter
Copy link

Codecov Report

Base: 97.09% // Head: 96.67% // Decreases project coverage by -0.41% ⚠️

Coverage data is based on head (7f2d2e5) compared to base (4bcae41).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   97.09%   96.67%   -0.42%     
==========================================
  Files          37       37              
  Lines        2167     2167              
  Branches      203      180      -23     
==========================================
- Hits         2104     2095       -9     
- Misses         37       41       +4     
- Partials       26       31       +5     
Impacted Files Coverage Δ
src/dvclive/dvc.py 89.89% <ø> (-1.28%) ⬇️
src/dvclive/live.py 93.80% <75.00%> (-3.06%) ⬇️
src/dvclive/studio.py 93.67% <0.00%> (-1.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit b1e04bf into main Dec 13, 2022
@daavoo daavoo deleted the clean-warnings branch December 13, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants