fastai: Log some params. #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
force-pushed
the
fastai-params
branch
2 times, most recently
from
f3c4086 to
a7ef397
Compare
daavoo
commented
Dec 19, 2022
src/dvclive/fastai.py
Outdated
Comment on lines
+26
to
+50
Contributor
Author
There was a problem hiding this comment.
@alex000kim Asked for your review since I know you use fastai.
Do you think these params are relevant enough for being "autologged"? Some missing?
There was a problem hiding this comment.
I'd add n_epoch and base_lr.
In general, you can log optimizer's hyperparams as done in wandb and comet integrations:
8 tasks
daavoo
force-pushed
the
fastai-params
branch
2 times, most recently
from
0a09d78 to
e91b14b
Compare
daavoo
force-pushed
the
fastai-params
branch
from
e91b14b to
038d29e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#317