live: Skip live.end calls inside context manager.
#436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
commented
Jan 30, 2023
Contributor
Author
daavoo
left a comment
daavoo
left a comment
There was a problem hiding this comment.
@dberenbaum I think we already discussed this somewhere but can't remember. Just found it convenient to have for iterative/example-repos-dev#161
Add `live._inside_with` boolean to handle it.
The idea is to include additional data in a experiment when using frameworks:
```python
from dvclive import Live
from dvclive.keras import DVCLiveCallback
with Live(save_dvc_exp=True) as live:
live.log_param("foo", 2)
model.fit(
x, y,
# Don't call live.end so additional stuff can be logged
callbacks=[DVCLiveCallback(live=live)])
# So it is possible to include additional data in the experiment
live.summary["out-of-loop-metric"] = 1
```
daavoo
force-pushed
the
add-inside-with
branch
from
7bc8131 to
0766888
Compare
dberenbaum
approved these changes
Jan 31, 2023
dberenbaum
left a comment
dberenbaum
left a comment
There was a problem hiding this comment.
Looks like it's in #367? I guess we need a docs update to say that end gets ignored inside the context manager?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
live._inside_withboolean to handle it.The idea is to include additional data in an experiment when using frameworks: