Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Mar 23, 2023

Falls back to using SubprocessSSHVendor instead of AsyncSSHVendor when:

  • we are inside git-bash/msys environment on windows
  • OpenSSH ~/.ssh/config exists and contains options which are unsupported by asyncssh

Fixes: treeverse/dvc#7702
Related: treeverse/dvc-ssh#20

Closes #208
Closes #210

@pmrowla pmrowla self-assigned this Mar 23, 2023
@pmrowla pmrowla force-pushed the dulwich-ssh-vendor branch from 897f872 to 4a7c947 Compare March 23, 2023 07:22
@pmrowla pmrowla force-pushed the dulwich-ssh-vendor branch 2 times, most recently from 1b16112 to 61bf1ad Compare March 23, 2023 07:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

❌ Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.35%. Comparing base (3a1df25) to head (a54dcf4).
⚠️ Report is 212 commits behind head on main.

Files with missing lines Patch % Lines
src/scmrepo/git/backend/dulwich/asyncssh_vendor.py 73.52% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   82.29%   82.35%   +0.05%     
==========================================
  Files          25       25              
  Lines        3497     3559      +62     
  Branches      608      622      +14     
==========================================
+ Hits         2878     2931      +53     
- Misses        527      532       +5     
- Partials       92       96       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pmrowla pmrowla force-pushed the dulwich-ssh-vendor branch from 61bf1ad to afc63b0 Compare March 23, 2023 07:51
@pmrowla pmrowla force-pushed the dulwich-ssh-vendor branch from afc63b0 to a54dcf4 Compare March 23, 2023 08:01
@pmrowla pmrowla merged commit 62ac00d into treeverse:main Mar 23, 2023
@pmrowla pmrowla deleted the dulwich-ssh-vendor branch March 23, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clone: use gitpython's CLI git first and fallback to dulwich if CLI git is not available erepo: ignores ssh-agent keys in windows git-bash

2 participants