disallow cred helper to return empty output #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #220 (comment), the issue appears to be from having the cache helper enabled in my git config:
I get the prompt as expected when I disable this. However, when it's enabled, I don't get a prompt, even if I have no credentials cached. For example, this fails:
The credential helper does not fail but returns an empty output in this scenario.
I notice we don't have any tests for any of the credential helper logic. Do we need to add something?
I don't mind if you take this over @pmrowla, but once I found the issue it wasn't any extra work to submit the PR.