Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Apr 12, 2023

Fixes treeverse/dvc#9007

  • adds support for AWS codecommit credential-helper

@pmrowla pmrowla self-assigned this Apr 12, 2023
@pmrowla pmrowla force-pushed the git-credential-path branch 2 times, most recently from 29b8a7f to f5313ac Compare April 12, 2023 05:25
@pmrowla pmrowla marked this pull request as draft April 12, 2023 05:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Patch coverage: 83.78% and project coverage change: +0.30 🎉

Comparison is base (3b05d6d) 81.04% compared to head (4092cd8) 81.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   81.04%   81.34%   +0.30%     
==========================================
  Files          27       27              
  Lines        3978     4005      +27     
  Branches      704      706       +2     
==========================================
+ Hits         3224     3258      +34     
+ Misses        633      624       -9     
- Partials      121      123       +2     
Impacted Files Coverage Δ
src/scmrepo/git/backend/dulwich/client.py 40.47% <0.00%> (-0.99%) ⬇️
src/scmrepo/git/credentials.py 60.55% <75.00%> (+2.87%) ⬆️
tests/test_credentials.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla force-pushed the git-credential-path branch from fcaeb3c to 4092cd8 Compare April 13, 2023 06:05
@pmrowla pmrowla marked this pull request as ready for review April 13, 2023 07:11
@pmrowla pmrowla merged commit 885a03d into treeverse:main Apr 13, 2023
@pmrowla pmrowla deleted the git-credential-path branch April 13, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc.repo.Repo.dvcfs.get: AWS Codecommit credential helper and cloning

2 participants