asyncssh: loosen upper version limit #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using wrong typehints - SSHConnection vs SSHClientConnection. And SFTPFileProtocol.read() is typed as requiring `read` and `offset` explicitly now, which has been updated in the test.
skshetry
reviewed
Mar 17, 2022
|
|
||
| async with sftp.open("test-repo.git/refs/heads/master") as fobj: | ||
| assert (await fobj.read()).strip() == rev | ||
| assert (await fobj.read(-1, 0)).strip() == rev |
Collaborator
There was a problem hiding this comment.
SFTPFileProtocol.read requires read and offset to be passed explicitly. This is most likely a bug in typings in asyncssh, but this does not hurt us that much, so just fixing it here.
skshetry
reviewed
Mar 17, 2022
| class AsyncSSHWrapper(BaseAsyncObject): | ||
| def __init__( | ||
| self, conn: "SSHConnection", proc: "SSHClientProcess", **kwargs | ||
| self, conn: "SSHClientConnection", proc: "SSHClientProcess", **kwargs |
Collaborator
There was a problem hiding this comment.
We were using incorrect type-hints. :)
skshetry
reviewed
Mar 17, 2022
| ] = _process_public_key_ok_gh | ||
|
|
||
| conn: "SSHClientConnection" = await asyncssh.connect( | ||
| conn = await asyncssh.connect( |
Collaborator
There was a problem hiding this comment.
No longer required, since asyncssh is now typed. :)
skshetry
reviewed
Mar 17, 2022
| proc: "SSHClientProcess" = await conn.create_process( | ||
| command, encoding=None | ||
| ) | ||
| proc = await conn.create_process(command, encoding=None) |
Collaborator
There was a problem hiding this comment.
No longer required, since asyncssh is now typed. :)
skshetry
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #43