From dee790d019b3ad30301086d50c35e2984796c183 Mon Sep 17 00:00:00 2001 From: Matt Seddon Date: Thu, 26 May 2022 11:19:56 +1000 Subject: [PATCH 1/2] show an empty state in the experiments tree when there are no columns in the project --- extension/src/experiments/index.ts | 8 +++++ .../src/test/suite/experiments/index.test.ts | 32 +++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/extension/src/experiments/index.ts b/extension/src/experiments/index.ts index 9f266c9b19..cdaa6839f2 100644 --- a/extension/src/experiments/index.ts +++ b/extension/src/experiments/index.ts @@ -320,6 +320,10 @@ export class Experiments extends BaseRepository { } public getExperiments() { + if (!this.columns.hasColumns()) { + return [] + } + return this.experiments.getExperiments() } @@ -332,6 +336,10 @@ export class Experiments extends BaseRepository { } public getSelectedRevisions() { + if (!this.columns.hasColumns()) { + return [] + } + return this.experiments.getSelectedRevisions() } diff --git a/extension/src/test/suite/experiments/index.test.ts b/extension/src/test/suite/experiments/index.test.ts index 63d84acc3f..ca47ca4bff 100644 --- a/extension/src/test/suite/experiments/index.test.ts +++ b/extension/src/test/suite/experiments/index.test.ts @@ -601,6 +601,7 @@ suite('Experiments Test Suite', () => { 'queued experiment cannot be selected' ).to.be.false }) + it('should be able to handle a message to select columns', async () => { const { columnsModel, experiments, messageSpy } = setupExperimentsAndMockCommands() @@ -1150,4 +1151,35 @@ suite('Experiments Test Suite', () => { expect(setContextValueSpy).not.to.be.called }) }) + + describe('Empty repository', () => { + it('should not return any experiments to the tree when there are no columns', async () => { + const { experiments } = buildExperiments(disposable, { + b9f016df00d499f6d2a73e7dc34d1600c78066eb: { + baseline: { + data: { + deps: {} + } + } + }, + workspace: { + baseline: { + data: { + deps: {} + } + } + } + }) + await experiments.isReady() + + expect( + experiments.getExperiments(), + 'should send no experiments to the tree' + ).to.deep.equal([]) + expect( + experiments.getSelectedRevisions(), + 'should show 0 selected experiments as selected in the description' + ).to.deep.equal([]) + }) + }) }) From f8abf3f3f2eabe74d6dcda29f152974524249815 Mon Sep 17 00:00:00 2001 From: Matt Seddon Date: Thu, 26 May 2022 11:33:40 +1000 Subject: [PATCH 2/2] reword test --- extension/src/test/suite/experiments/index.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension/src/test/suite/experiments/index.test.ts b/extension/src/test/suite/experiments/index.test.ts index ca47ca4bff..0f179d6b05 100644 --- a/extension/src/test/suite/experiments/index.test.ts +++ b/extension/src/test/suite/experiments/index.test.ts @@ -1153,7 +1153,7 @@ suite('Experiments Test Suite', () => { }) describe('Empty repository', () => { - it('should not return any experiments to the tree when there are no columns', async () => { + it('should not show any experiments in the experiments tree when there are no columns', async () => { const { experiments } = buildExperiments(disposable, { b9f016df00d499f6d2a73e7dc34d1600c78066eb: { baseline: {