Skip to content

readme: add ToC and Roadmap #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 30, 2022
Merged

readme: add ToC and Roadmap #1936

merged 22 commits into from
Jun 30, 2022

Conversation

@jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jun 22, 2022 •
edited
Loading

@jorgeorpinel jorgeorpinel mentioned this pull request Jun 22, 2022
Open
jorgeorpinel
jorgeorpinel commented Jun 22, 2022
View reviewed changes
@jorgeorpinel jorgeorpinel force-pushed the readme/known-limitations branch from 9ec9501 to 09a538d Compare June 22, 2022 05:27
@jorgeorpinel jorgeorpinel changed the title readme: add Known limitations section readme: add some sections Jun 23, 2022
jorgeorpinel
jorgeorpinel commented Jun 23, 2022
View reviewed changes
@jorgeorpinel jorgeorpinel self-assigned this Jun 23, 2022
@jorgeorpinel jorgeorpinel changed the title readme: add some sections readme: add ToC and Roadmap Jun 24, 2022
@jorgeorpinel jorgeorpinel marked this pull request as ready for review June 24, 2022 16:08
@jorgeorpinel jorgeorpinel force-pushed the readme/known-limitations branch from e4ff687 to 459ec23 Compare June 24, 2022 16:12
@jorgeorpinel jorgeorpinel force-pushed the readme/known-limitations branch from 459ec23 to 73d555a Compare June 24, 2022 16:12
@shcheklein

This comment was marked as duplicate.

Sign in to view
shcheklein
shcheklein reviewed Jun 25, 2022
View reviewed changes
shcheklein
shcheklein reviewed Jun 25, 2022
View reviewed changes
README.md
[workspace level]:
https://code.visualstudio.com/docs/getstarted/settings#_workspace-settings

## Developer roadmap
Copy link
Contributor

@shcheklein shcheklein Jun 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's actually create a board and put a link to it instead? For now either tickets or stubs are fine, we'll review it later

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Jun 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I made it into a lighter-looking bullet list since I can't make the board myself. Cc @mattseddon happy to link instead once one exists.

See https://github.com/iterative/vscode-dvc/tree/readme/known-limitations#developer-roadmap. Thanks

Copy link
Contributor

@mattseddon mattseddon Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll go through Q planning next week.

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we keep this open or merge (since it's approved) and revisit then?

Copy link
Contributor

@mattseddon mattseddon Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR meets the criteria to merge then feel free. We should keep everything moving.

shcheklein
shcheklein reviewed Jun 25, 2022
View reviewed changes
shcheklein
shcheklein reviewed Jun 25, 2022
View reviewed changes
jorgeorpinel added a commit that referenced this pull request Jun 25, 2022
@jorgeorpinel
walks: re-title and reformat DVC/ More Resources
863d735 
Extracted from #1936 (review)
@jorgeorpinel jorgeorpinel mentioned this pull request Jun 25, 2022
Merged
@jorgeorpinel jorgeorpinel requested review from mattseddon and removed request for mattseddon, rogermparent, sroy3 and wolmir June 25, 2022 03:44
makeitglitch
makeitglitch reviewed Jun 27, 2022
View reviewed changes
jorgeorpinel added a commit that referenced this pull request Jun 28, 2022
@jorgeorpinel
readme: try moving ToC to top
cf3184f 
per #1936 (comment)
@jorgeorpinel jorgeorpinel force-pushed the readme/known-limitations branch from cf3184f to 7427f05 Compare June 28, 2022 04:38
@jorgeorpinel jorgeorpinel requested a review from shcheklein June 28, 2022 04:50
jorgeorpinel
jorgeorpinel commented Jun 28, 2022
View reviewed changes
@shcheklein @jorgeorpinel
minor: remove the horizontal line
fb3dfb7 
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
@jorgeorpinel jorgeorpinel enabled auto-merge June 30, 2022 19:33
@jorgeorpinel jorgeorpinel removed the request for review from mattseddon June 30, 2022 19:34
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jun 30, 2022

Code Climate has analyzed commit ce3353a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.5% (0.0% change).

View more on Code Climate.

@jorgeorpinel jorgeorpinel merged commit 97b99e4 into main Jun 30, 2022
@jorgeorpinel jorgeorpinel deleted the readme/known-limitations branch June 30, 2022 19:54
mattseddon pushed a commit that referenced this pull request Jun 30, 2022
@jorgeorpinel
walks: re-title and update More Resources (#1948)
1906e00 
* walks: re-title and reformat DVC/ More Resources
Extracted from #1936 (review)

* walks: rename dvc-learn-more to more-resources
rel. #1948 (review)

* walks: update more-resources

* Update extension/resources/walkthrough/more-resources.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@mattseddon mattseddon mattseddon left review comments

@makeitglitch makeitglitch makeitglitch left review comments

@shcheklein shcheklein shcheklein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jorgeorpinel jorgeorpinel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jorgeorpinel @shcheklein @mattseddon @makeitglitch