Skip to content

Fix partially hidden header context menus #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Fix partially hidden header context menus #2204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de0f736
Fix hidden header context menus
julieg18 Aug 17, 2022
12ce90d
Merge branch 'main' into fix-hidden-head-context-menu
mattseddon Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webview/src/experiments/components/table/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding;
box-shadow: none;
position: sticky;
top: 0;
z-index: 4;
z-index: 5;
Copy link
Contributor Author

@julieg18 julieg18 Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed yet another small bug that I missed in #2133 😅. Looks like there was an issue with the z-index, causing the workspace row to have a higher stacking context than the head tooltips. Fixed by increasing the head z-index, making it higher than the workspace row.

Copy link
Contributor

@sroy3 sroy3 Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine as is, but setting the z indexes in variables might help keeping the indexes in order at a glance. That is if the workspace row has a set z-index.

}

.tableIndicators {
Expand Down