From 866c2222ec82d140ecb0e52dcd433cb3c7d3ddfa Mon Sep 17 00:00:00 2001 From: Matt Seddon Date: Mon, 22 Aug 2022 17:13:49 +1000 Subject: [PATCH] Replace vary with modify in variable names --- extension/src/experiments/webview/messages.ts | 6 +++--- extension/src/test/suite/experiments/index.test.ts | 6 +++--- extension/src/webview/contract.ts | 12 ++++++------ webview/src/experiments/components/table/Row.tsx | 6 +++--- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/extension/src/experiments/webview/messages.ts b/extension/src/experiments/webview/messages.ts index ad8a841332..ffab126dad 100644 --- a/extension/src/experiments/webview/messages.ts +++ b/extension/src/experiments/webview/messages.ts @@ -84,17 +84,17 @@ export class WebviewMessages { RegisteredCliCommands.EXPERIMENT_VIEW_BRANCH, { dvcRoot: this.dvcRoot, id: message.payload } ) - case MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_QUEUE: + case MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_QUEUE: return commands.executeCommand( RegisteredCliCommands.EXPERIMENT_VIEW_QUEUE, { dvcRoot: this.dvcRoot, id: message.payload } ) - case MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_RUN: + case MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_RUN: return commands.executeCommand( RegisteredCliCommands.EXPERIMENT_VIEW_RUN, { dvcRoot: this.dvcRoot, id: message.payload } ) - case MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_RESET_AND_RUN: + case MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_RESET_AND_RUN: return commands.executeCommand( RegisteredCliCommands.EXPERIMENT_VIEW_RESET_AND_RUN, { dvcRoot: this.dvcRoot, id: message.payload } diff --git a/extension/src/test/suite/experiments/index.test.ts b/extension/src/test/suite/experiments/index.test.ts index 168402925b..08520262e3 100644 --- a/extension/src/test/suite/experiments/index.test.ts +++ b/extension/src/test/suite/experiments/index.test.ts @@ -565,7 +565,7 @@ suite('Experiments Test Suite', () => { mockMessageReceived.fire({ payload: mockExperimentId, - type: MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_QUEUE + type: MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_QUEUE }) await tableChangePromise @@ -606,7 +606,7 @@ suite('Experiments Test Suite', () => { mockMessageReceived.fire({ payload: mockExperimentId, - type: MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_RUN + type: MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_RUN }) await tableChangePromise @@ -648,7 +648,7 @@ suite('Experiments Test Suite', () => { mockMessageReceived.fire({ payload: mockExperimentId, - type: MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_RESET_AND_RUN + type: MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_RESET_AND_RUN }) await tableChangePromise diff --git a/extension/src/webview/contract.ts b/extension/src/webview/contract.ts index dff05bb0a5..027757e064 100644 --- a/extension/src/webview/contract.ts +++ b/extension/src/webview/contract.ts @@ -38,9 +38,9 @@ export enum MessageFromWebviewType { SHARE_EXPERIMENT_AS_BRANCH = 'share-experiment-as-branch', TOGGLE_METRIC = 'toggle-metric', TOGGLE_PLOTS_SECTION = 'toggle-plots-section', - VARY_EXPERIMENT_PARAMS_AND_QUEUE = 'vary-experiment-params-and-queue', - VARY_EXPERIMENT_PARAMS_AND_RUN = 'vary-experiment-params-and-run', - VARY_EXPERIMENT_PARAMS_RESET_AND_RUN = 'vary-experiment-params-reset-and-run' + MODIFY_EXPERIMENT_PARAMS_AND_QUEUE = 'modify-experiment-params-and-queue', + MODIFY_EXPERIMENT_PARAMS_AND_RUN = 'modify-experiment-params-and-run', + MODIFY_EXPERIMENT_PARAMS_RESET_AND_RUN = 'modify-experiment-params-reset-and-run' } export type ColumnResizePayload = { @@ -91,15 +91,15 @@ export type MessageFromWebview = payload: string } | { - type: MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_QUEUE + type: MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_QUEUE payload: string } | { - type: MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_RUN + type: MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_RUN payload: string } | { - type: MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_RESET_AND_RUN + type: MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_RESET_AND_RUN payload: string } | { diff --git a/webview/src/experiments/components/table/Row.tsx b/webview/src/experiments/components/table/Row.tsx index 5c76b4c404..72674d3469 100644 --- a/webview/src/experiments/components/table/Row.tsx +++ b/webview/src/experiments/components/table/Row.tsx @@ -127,19 +127,19 @@ const getRunResumeOptions = ( return [ withId( 'Modify, Reset and Run', - MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_RESET_AND_RUN, + MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_RESET_AND_RUN, isCheckpoint || !projectHasCheckpoints, resetNeedsSeparator ), withId( projectHasCheckpoints ? 'Modify and Resume' : 'Modify and Run', - MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_RUN, + MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_RUN, isCheckpoint, runNeedsSeparator ), withId( 'Modify and Queue', - MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_QUEUE, + MessageFromWebviewType.MODIFY_EXPERIMENT_PARAMS_AND_QUEUE, isCheckpoint ) ]