Skip to content

Add hints into experiment table row action tooltips #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Add hints into experiment table row action tooltips #2567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions webview/src/experiments/components/table/CellRowActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,14 @@ export const CellRowAction: React.FC<CellRowActionProps> = ({
)
}

const getTooltipContent = (determiner: boolean, text: string): string =>
determiner ? `Un${text.toLowerCase()}` : text
const getTooltipContent = (
determiner: boolean,
action: string,
helperText?: string
): string =>
'Click to ' +
(determiner ? `un${action}` : action) +
(helperText ? `\n${helperText}` : '')

export const CellRowActions: React.FC<CellRowActionsProps> = ({
bulletColor,
Expand All @@ -83,7 +89,7 @@ export const CellRowActions: React.FC<CellRowActionsProps> = ({
showSubRowStates={showSubRowStates}
subRowsAffected={selections}
testId={'row-action-checkbox'}
tooltipContent={getTooltipContent(isRowSelected, 'Select')}
tooltipContent={getTooltipContent(isRowSelected, 'select the row')}
>
<VSCodeCheckbox
{...clickAndEnterProps(toggleRowSelection)}
Expand All @@ -94,7 +100,11 @@ export const CellRowActions: React.FC<CellRowActionsProps> = ({
showSubRowStates={showSubRowStates}
subRowsAffected={stars}
testId={'row-action-star'}
tooltipContent={getTooltipContent(!!starred, 'Star')}
tooltipContent={getTooltipContent(
!!starred,
'star',
'To filter by stars click the star icon above the filters tree\nor use "DVC: Filter Experiments Table to Starred" from the command palette.'
)}
>
<div
className={styles.starSwitch}
Expand All @@ -118,7 +128,11 @@ export const CellRowActions: React.FC<CellRowActionsProps> = ({
showSubRowStates={showSubRowStates}
subRowsAffected={plotSelections}
testId={'row-action-plot'}
tooltipContent={getTooltipContent(!!bulletColor, 'Plot')}
tooltipContent={getTooltipContent(
!!bulletColor,
'plot',
'To open the plots view click the plot icon in the top left corner\nor use "DVC: Show Plots" from the command palette.'
)}
onClick={toggleExperiment}
>
<span className={styles.bullet} style={{ color: bulletColor }} />
Expand Down