Fix plots file watchers (diff output key is not always a file) #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
fix-top-level-watchers
branch
2 times, most recently
from
d790043 to
5f2f179
Compare
mattseddon
force-pushed
the
fix-top-level-watchers
branch
from
5f2f179 to
b72f392
Compare
mattseddon
commented
Nov 29, 2022
|
|
||
| abstract managedUpdate(path?: string): Promise<unknown> | ||
|
|
||
| protected abstract collectFiles(data: T): string[] |
Contributor
Author
There was a problem hiding this comment.
[F] TIL this is possible.
mattseddon
commented
Nov 29, 2022
| ...args | ||
| ) | ||
|
|
||
| this.notifyChanged({ data, revs }) |
Contributor
Author
There was a problem hiding this comment.
[F] We don't want to delay updating the rest of the app whilst we mess around looking for files to watch.
mattseddon
force-pushed
the
fix-top-level-watchers
branch
2 times, most recently
from
8e422e0 to
fbfff9a
Compare
Contributor
Author
|
I had to update the test fixture because the Windows tests were failing. |
mattseddon
changed the title
sroy3
approved these changes
Nov 29, 2022
mattseddon
force-pushed
the
fix-top-level-watchers
branch
from
fbfff9a to
42f86d8
Compare
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 42f86d8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.9% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #2852 <- thisCloses #2851.
☝🏻 I actually remembered correctly.
Unfortunately, I realised that the key can actually be the plot's title which means we need to interrogate the data 😢.