Hidden: Add and remove branches to the experiments table #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroy3
commented
Apr 13, 2023
mattseddon
approved these changes
Apr 14, 2023
| @@ -0,0 +1,3 @@ | |||
| export const featureFlag = { | |||
Contributor
There was a problem hiding this comment.
[Q] WDYT about making this "updatable" from an environment variable. E.g something set in .vscode/launch.json?
Contributor
Author
There was a problem hiding this comment.
Only thing left to do. I'll do this as my next follow up. Just so we have a real branch and PR related to feature flags (this feature flag one is mainly a hack).
…code-dvc into add-remove-branches
|
Code Climate has analyzed commit e930647 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 89.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1966
Screen.Recording.2023-04-12.at.10.17.21.AM.mov
Hidden behind a feature flag for now until it actually does something in the table. I wanted to easily separate the collection of data from branch selection as this is already big enough. Might also be easier to merge with a feature flag than start a chain on PR.