Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for AWS_SECURITY_TOKEN #105

Closed
mgmarino opened this issue Jun 9, 2020 · 4 comments
Closed

Remove support for AWS_SECURITY_TOKEN #105

mgmarino opened this issue Jun 9, 2020 · 4 comments

Comments

@mgmarino
Copy link

mgmarino commented Jun 9, 2020

First off, great little tool, we are very happy to use it.

This issue is to consider dropping support for AWS_SECURITY_TOKEN. AWS switched over its usage 6 years ago and most documentation only references AWS_SESSION_TOKEN now. By retaining it, I believe it can only create confusion. Indeed, in our case if created some hard to track down issues when: the standard environment variables were updated and we forgot to update AWS_SECURITY_TOKEN env var as well.

My proposal would be the following:

  • Remove default export of AWS_SECURITY_TOKEN, but perhaps allow it to be exported if a configuration is set.

I'm happy to open a PR, but would like to get any comments/concerns first.

@mbarneyjr
Copy link
Member

mbarneyjr commented Aug 21, 2020

Hi, sorry for the delay in response! I've implemented this and a few other fixes. This should be found in pre release 4.5.0a1. I'll deploy this to release 4.5.0 once I'm confident in the changes. If you experience any issues with pre release 4.5.0a1 please update this issue, thanks!

@mgmarino
Copy link
Author

mgmarino commented Aug 27, 2020

Thanks, I have been using 4.5.0a3 and haven't seen any issues.

@mgmarino
Copy link
Author

mgmarino commented Nov 19, 2020

@mbarneyjr Thanks for this! Any idea when you might push a release?

@mbarneyjr
Copy link
Member

mbarneyjr commented Nov 20, 2020

Sorry for the delay, deployed to 4.5.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants