Skip to content

fix: saml order of principal and role mixed - #164

Merged
lhendrick-t10 merged 1 commit into
trek10inc:masterfrom
Timboo89:fix/saml-order-of-principal-and-role
Aug 3, 2023
Merged

lhendrick-t10 merged 1 commit into
trek10inc:masterfrom
Timboo89:fix/saml-order-of-principal-and-role

Conversation

@Timboo89

Copy link
Copy Markdown
Contributor

Hi there,

I was just writing a saml plugin, realizing that it always came to issues because of the order between role arn and principal arn.
Fixes:

  1. In the saml response, you get the arns like this: "role-arn,principal-arn" [1]
    You had it correct once and once and than once the other way around.
  2. Parsing the actual role arn and principal arn from the saml response was also in the wrong order here and here

In case (1) differs from response to response I'd be glad to write a less static check here.

[1] At least this is how the response looked like I was receiving.

@lhendrick-t10
lhendrick-t10 self-requested a review July 25, 2023 20:49
@lhendrick-t10 lhendrick-t10 self-assigned this Jul 25, 2023
@lhendrick-t10
lhendrick-t10 merged commit d803c12 into trek10inc:master Aug 3, 2023

@lhendrick-t10 lhendrick-t10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Timboo89 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants