Feat/132 honor xdg directories #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtskillman
force-pushed
the
feat/132-honor-xdg-directories
branch
from
dca6555 to
a2c859b
Compare
The unit tests where failing when the environment variables for the AWS config and credential files were set. There is now patches on the unit test to make sure that the environment variables are not set when running the tests.
There is now support for the XDG base directories: - XDG_CONFIG_HOME - XDG_CACHE_HOME - XDG_DATA_HOME
The call count to makedirs needed to be increased to 2 after the XDG base directory support.
mtskillman
force-pushed
the
feat/132-honor-xdg-directories
branch
from
a2c859b to
e9aba8d
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #138
see #132