Skip to content

Enable external ids#56

Merged
mbarneyjr merged 3 commits into
trek10inc:masterfrom
aarongorka:enable-external-ids
Jul 4, 2019
Merged

Enable external ids#56
mbarneyjr merged 3 commits into
trek10inc:masterfrom
aarongorka:enable-external-ids

Conversation

@aarongorka

Copy link
Copy Markdown

This also includes #55 , not sure what's going on there. Can we merge this if #54 isn't going to be merged?

This is useful if you are using an external tool to authenticate via
e.g. SAML and write the credentials to the `~/.aws/credentials` file.
@mbarneyjr

Copy link
Copy Markdown
Member

Wanted to make a note that we'll review this and push an update to pypi. It might take a little while though, we're also working on an update to awsume, rearchitecting a lot of the core, but these changes will be incorporated to awsume v3 before the v4 release.

Thanks for the MR!

@mike-mosher

Copy link
Copy Markdown

+1 on this functionality. Would really help in our workflow

@mbarneyjr

Copy link
Copy Markdown
Member

Just reviewed this, everything looks good except for in one spot

In awsumepy.py, lines 871-879 need to be swapped with lines 862-869. This is because a profile that has a session token in it wouldn't normally have an mfa_serial, role_arn, or source_profile, which triggers passes the condition that is checked before we check for the session token. I'll fix this after it's merged though, just an fyi

Thanks a ton for the MR! After I review the rest of the currently open MR's I'll release to pypi

aarongorka added a commit to aarongorka/awsume that referenced this pull request Jul 4, 2019
@mbarneyjr mbarneyjr merged commit c8a4713 into trek10inc:master Jul 4, 2019
ryansb referenced this pull request in ryansb/awsume Jul 14, 2021
Enable external ids, supports session_token in profiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants