Adding chmod to file operations. #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the awsume command will take whatever umask is set and for users this is rarely a secure set of permissions. As we are dealing with aws credentials we should ensure the cache files have secure permissions only the user can see.
Member
|
Hey @lazzurs , Thanks for the PR! We'll take a look at this and do some testing. We'd love to have this functionality in awsume, thanks! |
Member
|
Merged and released under 4.1.11, thanks again @lazzurs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the awsume command will take whatever umask is set and for
users this is rarely a secure set of permissions.
As we are dealing with aws credentials we should ensure the cache files
have secure permissions only the user can see.