Repository navigation
Fixes #91: refresh role credentials sooner - #94
Merged
Merged
Conversation
The check to refresh role credentials needs to take into account that they may expire within 60s so that we don't have a period of time where the role credentials have expired. This also ensure that if we never sleep for a negative time as this leads to autoawsume exiting with a failure.
Member
|
Hi @valdisrigdon ! Thanks for the PR! Merging and deploying under |
ryansb
referenced
this pull request
in ryansb/awsume
Jul 14, 2021
Fixes #91: refresh role credentials sooner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check to refresh role credentials needs to take into account that
they may expire within 60s so that we don't have a period of time where
the role credentials have expired.
This also ensure that if we never sleep for a negative time as this
leads to autoawsume exiting with a failure.