Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tremor compile on x86_64-unknown-linux-gnu #1522

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

scrabsha
Copy link
Contributor

Pull request

Description

Tremor uses simd-json in order to get blazingly fast JSON parsing.
This crate aims to use CPU-specific SIMD instructions. We need to tell
rustc that these instructions are available.

Checklist

  • The RFC, if required, has been submitted and approved (not required)
  • Any user-facing impact of the changes is reflected in docs.tremor.rs (none)
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below) (not required)

Tremor uses `simd-json` in order to get blazingly fast JSON parsing.
This crate aims to use CPU-specific SIMD instructions. We need to tell
`rustc` that these instructions are available.

Signed-off-by: Sasha Pourcelot <sasha.pourcelot@protonmail.com>
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 good catch!

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2067553232

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.005%) to 87.367%

Files with Coverage Reduction New Missed Lines %
tremor-script/src/ast/eq.rs 1 71.84%
tremor-script/src/ast/walkers.rs 1 75.35%
tremor-value/src/value.rs 1 98.7%
Totals Coverage Status
Change from base Build 2027316573: 0.005%
Covered Lines: 18734
Relevant Lines: 21443

💛 - Coveralls

@mfelsche mfelsche merged commit ca5234b into tremor-rs:main Mar 31, 2022
@scrabsha scrabsha deleted the please-compile branch March 31, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants