Fix a hang upon pause/resume.#1537
Merged
Merged
Conversation
Licenser
previously approved these changes
Apr 13, 2022
Collaborator
Pull Request Test Coverage Report for Build 2159915354
💛 - Coveralls |
The cause was that upon resume we only woke 2 of the maximum 3 quiescence beacons (1 for ConnectorContext, 1 for SourceContext, 1 for SinkContext). I did miss that we actually clone it three times instead of 2. Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
55f0c21 to
c930b61
Compare
Licenser
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cause was that upon resume we only woke 2 of the maximum 3 quiescence beacons (1 for ConnectorContext, 1 for SourceContext, 1 for SinkContext).
I did miss that we actually clone it three times instead of 2.
Pull request
Checklist
Performance
Shouldn't have any impact