Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a hang upon pause/resume. #1537

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix a hang upon pause/resume. #1537

merged 1 commit into from
Apr 13, 2022

Conversation

mfelsche
Copy link
Member

The cause was that upon resume we only woke 2 of the maximum 3 quiescence beacons (1 for ConnectorContext, 1 for SourceContext, 1 for SinkContext).
I did miss that we actually clone it three times instead of 2.

Pull request

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Shouldn't have any impact

darach
darach previously approved these changes Apr 13, 2022
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Licenser
Licenser previously approved these changes Apr 13, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2159915354

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 85.394%

Files with Coverage Reduction New Missed Lines %
src/connectors.rs 1 85.89%
src/system/flow.rs 1 89.9%
src/connectors/source.rs 4 81.24%
Totals Coverage Status
Change from base Build 2156195923: -0.002%
Covered Lines: 39534
Relevant Lines: 46296

💛 - Coveralls

The cause was that upon resume we only woke 2 of the maximum 3 quiescence beacons (1 for ConnectorContext, 1 for SourceContext, 1 for SinkContext).
I did miss that we actually clone it three times instead of 2.

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
@mfelsche mfelsche dismissed stale reviews from Licenser and darach via c930b61 April 13, 2022 09:46
@Licenser Licenser merged commit 28d37fc into main Apr 13, 2022
@Licenser Licenser deleted the quiescence-wakeup-fix branch April 13, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants