Fix bug that tremor run would always ever run for exactly 150s

[Licenser]

Pull request

Description

Tremor run had originally a timeout running for exactly 150s, this makes no sense of all, so we join world and let the runtime decide when to stop.

Checklist

• The RFC, if required, has been submitted and approved
• Any user-facing impact of the changes is reflected in docs.tremor.rs
• The code is tested
• Use of unsafe code is reasoned about in a comment
• Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
• The performance impact of the change is measured (see below)

Performance

no runtime changes

[mfelsche]

🤦 lets merge this quickly, so no one sees it.

[codecov]

Codecov Report

Merging #1582 (610c4a8) into main (a05b769) will increase coverage by 1.54%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
+ Coverage   85.74%   87.28%   +1.54%     
==========================================
  Files         232      254      +22     
  Lines       47188    50159    +2971     
==========================================
+ Hits        40461    43781    +3320     
+ Misses       6727     6378     -349     

Flag	Coverage Δ
clicommand	14.42% <0.00%> (?)
cliintegration	52.55% <50.00%> (?)
cliunit	13.45% <0.00%> (?)
unittests	85.77% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
tremor-cli/src/run.rs	67.80% <0.00%> (ø)
tremor-cli/src/test.rs	55.44% <50.00%> (ø)
src/connectors.rs	87.30% <100.00%> (+1.23%)	⬆️
src/connectors/impls/stdio.rs	74.60% <100.00%> (+70.71%)	⬆️
tremor-value/src/value.rs	98.99% <0.00%> (ø)
build.rs
tremor-script/build.rs
tremor-cli/src/report.rs	72.00% <0.00%> (ø)
tremor-cli/src/test/metadata.rs	100.00% <0.00%> (ø)
tremor-cli/src/test/assert.rs	68.16% <0.00%> (ø)
... and 83 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05b769...610c4a8. Read the comment docs.

[mfelsche]

I think in this case the codecov/patch metric is not applicable. Those lines weren't tested before.

Would you mind adding a test for the run_troy_source function?

[mfelsche]

Should we add a coverage exclude for tremor-cli?

[Licenser]

idk that feels a bit "wrong" I want to try to see if we can use a wrapper to include more of the integration tests, that'd be really handy.

[Licenser]

Okay I got it working but cargo-llvm-cov has a limitation that prevents us from using it: taiki-e/cargo-llvm-cov#160

[mfelsche]

At least now we know that the tests in tremor-cli have been successful at one point in time.