Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements - Publishing packages #1609

Merged
merged 12 commits into from
May 4, 2022
Merged

Conversation

PrimalPimmy
Copy link
Contributor

Pull request

Description

  • Added drop down menu feature on Draft-Release workflow which has options: major, minor, patch, rc
  • Improved release process by no longer requiring to input old version and various other small changes
  • All workspaces have the same version now
  • Publish feature to crates.io (only tremor-common package for now)

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy PrimalPimmy changed the title Publish CI Improvements - Publishing packages May 4, 2022
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
type: choice
description: "Which version you'd like to release?"
options:
- major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for -rc.2 but the workflow a;sp needs to allow to go from version -> version+1-rc.1 -...> version+1-rc.N -> version+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it in the next PR! thanks for pointing out!

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice!

@coveralls
Copy link
Collaborator

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2272453227

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 85.618%

Files with Coverage Reduction New Missed Lines %
src/connectors/sink.rs 1 82.75%
src/pipeline.rs 1 76.39%
Totals Coverage Status
Change from base Build 2271225066: 0.006%
Covered Lines: 40334
Relevant Lines: 47109

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1609 (40e7f7c) into main (2ade398) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         232      232           
  Lines       47109    47109           
=======================================
+ Hits        40331    40334    +3     
+ Misses       6778     6775    -3     
Flag Coverage Δ
unittests 85.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pipeline.rs 76.38% <0.00%> (-0.28%) ⬇️
src/connectors/sink.rs 82.75% <0.00%> (-0.21%) ⬇️
src/connectors/source.rs 80.59% <0.00%> (+0.11%) ⬆️
src/version.rs 87.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ade398...40e7f7c. Read the comment docs.

@Licenser Licenser enabled auto-merge (rebase) May 4, 2022 21:41
@Licenser Licenser merged commit ca0bf60 into tremor-rs:main May 4, 2022
@PrimalPimmy PrimalPimmy deleted the publish branch May 5, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants