-
Notifications
You must be signed in to change notification settings - Fork 126
CI Improvements - Publishing packages #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
| type: choice | ||
| description: "Which version you'd like to release?" | ||
| options: | ||
| - major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for -rc.2 but the workflow a;sp needs to allow to go from version -> version+1-rc.1 -...> version+1-rc.N -> version+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it in the next PR! thanks for pointing out!
Licenser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 nice!
Pull Request Test Coverage Report for Build 2272453227
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## main #1609 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 232 232
Lines 47109 47109
=======================================
+ Hits 40331 40334 +3
+ Misses 6778 6775 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Pull request
Description
Checklist
Performance