Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive options for Drafting release #1624

Merged
merged 1 commit into from
May 6, 2022

Conversation

PrimalPimmy
Copy link
Contributor

@PrimalPimmy PrimalPimmy commented May 6, 2022

Signed-off-by: PrimalPimmy Prashant20.pm@gmail.com

Pull request

Description

  • Made more descriptive drop down release options for making a draft release.
  • Added caching for cargo-edit package during draft release phase.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1624 (b381fd9) into main (42565d5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
+ Coverage   85.60%   85.62%   +0.01%     
==========================================
  Files         232      232              
  Lines       47109    47109              
==========================================
+ Hits        40330    40336       +6     
+ Misses       6779     6773       -6     
Flag Coverage Δ
unittests 85.62% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/source.rs 80.59% <0.00%> (+0.11%) ⬆️
src/connectors.rs 86.06% <0.00%> (+0.15%) ⬆️
src/version.rs 87.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42565d5...b381fd9. Read the comment docs.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2284421359

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 85.623%

Totals Coverage Status
Change from base Build 2283839993: 0.01%
Covered Lines: 40336
Relevant Lines: 47109

💛 - Coveralls

Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement!

@Licenser Licenser merged commit fecb7ea into tremor-rs:main May 6, 2022
@PrimalPimmy PrimalPimmy deleted the CI branch May 6, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants