Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated cargo publish jobs #1644

Merged
merged 6 commits into from
May 11, 2022
Merged

Separated cargo publish jobs #1644

merged 6 commits into from
May 11, 2022

Conversation

PrimalPimmy
Copy link
Contributor

@PrimalPimmy PrimalPimmy commented May 11, 2022

Pull request

Description

  • Separated publishing cargo packages into a separate job for easy re running in case of failure
  • Updated Changelog

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1644 (7292af5) into main (226f93f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1644   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files         232      232           
  Lines       47188    47188           
=======================================
+ Hits        40460    40463    +3     
+ Misses       6728     6725    -3     
Flag Coverage Δ
unittests 85.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/source/channel_source.rs 78.33% <0.00%> (-1.67%) ⬇️
src/system/flow_supervisor.rs 85.59% <0.00%> (-0.85%) ⬇️
src/connectors.rs 86.06% <0.00%> (+0.15%) ⬆️
src/version.rs 87.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226f93f...7292af5. Read the comment docs.

@Licenser Licenser merged commit 3373de5 into tremor-rs:main May 11, 2022
@PrimalPimmy PrimalPimmy deleted the fixes branch May 11, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants