Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish during release improvements #1649

Merged
merged 9 commits into from
May 12, 2022
Merged

Conversation

PrimalPimmy
Copy link
Contributor

@PrimalPimmy PrimalPimmy commented May 12, 2022

Pull request

Description

  • Separated each publish into different jobs
  • Added a pre-release condition during release

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1649 (ea3b8d8) into main (09376fc) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   87.29%   87.30%           
=======================================
  Files         254      254           
  Lines       50159    50159           
=======================================
+ Hits        43788    43792    +4     
+ Misses       6371     6367    -4     
Flag Coverage Δ
clicommand 14.42% <ø> (ø)
cliintegration 52.59% <ø> (+0.16%) ⬆️
cliunit 13.45% <ø> (ø)
unittests 85.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/instance.rs 58.33% <0.00%> (-8.34%) ⬇️
src/system/flow_supervisor.rs 87.28% <0.00%> (-0.85%) ⬇️
src/connectors/source.rs 87.02% <0.00%> (-0.35%) ⬇️
src/connectors.rs 87.15% <0.00%> (-0.16%) ⬇️
src/pipeline.rs 86.94% <0.00%> (+0.27%) ⬆️
tremor-cli/src/test/before.rs 78.36% <0.00%> (+0.58%) ⬆️
src/connectors/utils/reconnect.rs 95.85% <0.00%> (+0.82%) ⬆️
tremor-cli/src/server.rs 65.54% <0.00%> (+0.84%) ⬆️
src/connectors/impls/unix_socket/client.rs 91.80% <0.00%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09376fc...ea3b8d8. Read the comment docs.

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy PrimalPimmy marked this pull request as draft May 12, 2022 12:24
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy PrimalPimmy marked this pull request as ready for review May 12, 2022 12:55
@PrimalPimmy PrimalPimmy requested a review from Licenser May 12, 2022 12:55
@Licenser Licenser enabled auto-merge (rebase) May 12, 2022 14:01
@Licenser Licenser merged commit 82df07b into tremor-rs:main May 12, 2022
@PrimalPimmy PrimalPimmy deleted the publish branch May 12, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants