Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api sub command from cli #1650

Merged
merged 5 commits into from
May 17, 2022
Merged

Remove api sub command from cli #1650

merged 5 commits into from
May 17, 2022

Conversation

darach
Copy link
Member

@darach darach commented May 12, 2022

Signed-off-by: Darach Ennis darach@gmail.com

Pull request

Remove tremor api sub command from cli

Description

Remove the tremor api sub command from the cli and remove cli driven tests.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behaviour
  • The performance impact of the change is measured (see below)

Performance

No impact

Notes

  • breaking change in v0.12 as tremor api no longer present in cli

Signed-off-by: Darach Ennis <darach@gmail.com>
…aking change

Signed-off-by: Darach Ennis <darach@gmail.com>
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1650 (19af1d9) into main (d8f970d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1650      +/-   ##
==========================================
- Coverage   87.52%   87.50%   -0.02%     
==========================================
  Files         254      254              
  Lines       50210    50209       -1     
==========================================
- Hits        43944    43937       -7     
- Misses       6266     6272       +6     
Flag Coverage Δ
clicommand 14.40% <ø> (-0.01%) ⬇️
cliintegration 52.41% <ø> (-0.19%) ⬇️
cliunit 13.42% <ø> (-0.01%) ⬇️
unittests 86.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tremor-cli/src/cli.rs 53.42% <ø> (-1.37%) ⬇️
tremor-cli/src/main.rs 40.00% <ø> (+1.29%) ⬆️
src/connectors/utils/metrics.rs 92.39% <0.00%> (-2.18%) ⬇️
tremor-cli/src/test/process.rs 71.34% <0.00%> (-1.22%) ⬇️
src/connectors/utils/reconnect.rs 95.02% <0.00%> (-0.83%) ⬇️
src/connectors/impls/kafka/producer.rs 74.36% <0.00%> (-0.73%) ⬇️
tremor-cli/src/test/before.rs 77.77% <0.00%> (-0.59%) ⬇️
src/connectors/sink.rs 87.26% <0.00%> (-0.42%) ⬇️
src/system/flow.rs 90.20% <0.00%> (-0.19%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f970d...19af1d9. Read the comment docs.

@Licenser
Copy link
Member

  • 1k LOC <3 love it

@mfelsche mfelsche enabled auto-merge (rebase) May 13, 2022 07:44
mfelsche
mfelsche previously approved these changes May 13, 2022
@Licenser
Copy link
Member

Seems like some of the other integration tests need some adjusting to work again with this change

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
@mfelsche mfelsche merged commit 65c161c into main May 17, 2022
@mfelsche mfelsche deleted the de-remove-cli-api-subcommand branch May 17, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants