Fix bench connector not stopping

[mfelsche]

Pull request

Description

The bench connector actually wasn't stopping when stop_after_secs wasn't configured, only iters.
Adapted it to stop after the expected number of events in that case.
Also added tests and switched it to not terminate the process directly, but to stop the world.

Related

Checklist

• The RFC, if required, has been submitted and approved
• Any user-facing impact of the changes is reflected in docs.tremor.rs
• The code is tested
• Use of unsafe code is reasoned about in a comment
• Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
• The performance impact of the change is measured (see below)

Performance

Didn't test yet.

[Licenser]

🪨

[codecov]

Codecov Report

Merging #1651 (1468e11) into main (82df07b) will increase coverage by 0.18%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
+ Coverage   87.32%   87.51%   +0.18%     
==========================================
  Files         254      254              
  Lines       50159    50200      +41     
==========================================
+ Hits        43803    43934     +131     
+ Misses       6356     6266      -90     

Flag	Coverage Δ
clicommand	14.41% <0.00%> (-0.02%)	⬇️
cliintegration	52.56% <64.44%> (-0.08%)	⬇️
cliunit	13.43% <0.00%> (-0.02%)	⬇️
unittests	86.30% <91.11%> (+0.54%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/connectors/impls/gbq/writer/sink.rs	84.89% <ø> (ø)
src/connectors/impls/bench.rs	84.96% <92.40%> (+39.83%)	⬆️
src/connectors.rs	87.24% <100.00%> (-0.53%)	⬇️
src/system/flow.rs	90.20% <100.00%> (-0.08%)	⬇️
src/system/flow_supervisor.rs	88.13% <100.00%> (ø)
src/instance.rs	58.33% <0.00%> (-8.34%)	⬇️
src/connectors/sink/channel_sink.rs	82.40% <0.00%> (-3.20%)	⬇️
src/connectors/sink.rs	87.26% <0.00%> (-0.62%)	⬇️
src/connectors/impls/ws/server.rs	94.62% <0.00%> (-0.54%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82df07b...1468e11. Read the comment docs.

[Licenser]

🚀