Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw payload support #1653

Merged
merged 1 commit into from
May 13, 2022
Merged

Raw payload support #1653

merged 1 commit into from
May 13, 2022

Conversation

Licenser
Copy link
Member

Pull request

Description

This adds elastic.raw_payload to the elastic connector. For update actions this will not wrap the body into {"doc": ...} but instead let the user provide the whole raw body with any additional items they desire.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

The added overhead is one if which will not impact performance on an elastic search endpoint

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1653 (06e87d8) into main (e655da0) will increase coverage by 31.50%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1653       +/-   ##
===========================================
+ Coverage   56.02%   87.52%   +31.50%     
===========================================
  Files         243      254       +11     
  Lines       36909    50203    +13294     
===========================================
+ Hits        20678    43942    +23264     
+ Misses      16231     6261     -9970     
Flag Coverage Δ
clicommand 14.40% <0.00%> (-0.01%) ⬇️
cliintegration 52.37% <85.71%> (-0.01%) ⬇️
cliunit 13.43% <0.00%> (-0.01%) ⬇️
unittests 86.31% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/elastic.rs 88.64% <100.00%> (+12.74%) ⬆️
tremor-script/src/std_lib/system.rs 92.85% <0.00%> (-7.15%) ⬇️
src/connectors/impls/otel.rs 96.96% <0.00%> (-3.04%) ⬇️
src/errors.rs 80.78% <0.00%> (-1.29%) ⬇️
tremor-script/src/ast/visitors.rs 99.28% <0.00%> (-0.72%) ⬇️
src/lib.rs 100.00% <0.00%> (ø)
src/version.rs 100.00% <0.00%> (ø)
tremor-script/src/lib.rs 100.00% <0.00%> (ø)
tremor-script/src/std_lib/re.rs 100.00% <0.00%> (ø)
tremor-script/src/std_lib/url.rs 100.00% <0.00%> (ø)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e655da0...06e87d8. Read the comment docs.

@Licenser Licenser enabled auto-merge (rebase) May 13, 2022 10:04
@Licenser Licenser merged commit 3f85096 into main May 13, 2022
@Licenser Licenser deleted the es-raw-payload branch May 13, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc_as_upsert support for ES update
2 participants