Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tremor-Influx publishing #1655

Merged
merged 2 commits into from
May 13, 2022
Merged

Fix tremor-Influx publishing #1655

merged 2 commits into from
May 13, 2022

Conversation

PrimalPimmy
Copy link
Contributor

@PrimalPimmy PrimalPimmy commented May 13, 2022

Signed-off-by: PrimalPimmy Prashant20.pm@gmail.com

Pull request

Description

  • Fix tremor-influx publishing

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1655 (9e5b971) into main (053c8dd) will increase coverage by 3.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
+ Coverage   83.82%   87.54%   +3.71%     
==========================================
  Files         254      254              
  Lines       50203    50203              
==========================================
+ Hits        42082    43948    +1866     
+ Misses       8121     6255    -1866     
Flag Coverage Δ
clicommand 14.41% <ø> (ø)
cliintegration 52.56% <ø> (?)
cliunit 13.43% <ø> (ø)
unittests 86.30% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tremor-value/src/value.rs 98.99% <0.00%> (-0.10%) ⬇️
tremor-script/src/lexer.rs 92.38% <0.00%> (+0.23%) ⬆️
tremor-script/src/ast.rs 94.03% <0.00%> (+0.26%) ⬆️
tremor-pipeline/src/op/trickle/window.rs 95.73% <0.00%> (+0.26%) ⬆️
src/connectors/impls/bench.rs 84.96% <0.00%> (+0.30%) ⬆️
tremor-value/src/serde/value/de.rs 66.14% <0.00%> (+0.31%) ⬆️
src/system/flow.rs 90.39% <0.00%> (+0.56%) ⬆️
tremor-script/src/interpreter.rs 92.78% <0.00%> (+0.73%) ⬆️
tremor-script/src/interpreter/expr.rs 90.05% <0.00%> (+0.80%) ⬆️
src/connectors/impls/tcp/client.rs 92.38% <0.00%> (+0.95%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053c8dd...9e5b971. Read the comment docs.

@PrimalPimmy PrimalPimmy changed the title Influx Fix tremor-Influx publishing May 13, 2022
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Licenser Licenser merged commit 473ee86 into tremor-rs:main May 13, 2022
@PrimalPimmy PrimalPimmy deleted the influx branch May 18, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants