Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure bench connector never writes more events that it should #1662

Merged
merged 2 commits into from
May 16, 2022

Conversation

mfelsche
Copy link
Member

when iters is configured.

Pull request

Description

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

when iters is configured.

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Licenser
Licenser previously approved these changes May 16, 2022
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Licenser Licenser enabled auto-merge (rebase) May 16, 2022 09:56
@mfelsche mfelsche marked this pull request as draft May 16, 2022 09:56
auto-merge was automatically disabled May 16, 2022 09:56

Pull request was converted to draft

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1662 (9e9d0ae) into main (244fb0e) will increase coverage by 0.04%.
The diff coverage is 91.83%.

@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
+ Coverage   87.51%   87.56%   +0.04%     
==========================================
  Files         254      254              
  Lines       50203    50210       +7     
==========================================
+ Hits        43937    43968      +31     
+ Misses       6266     6242      -24     
Flag Coverage Δ
clicommand 14.40% <0.00%> (-0.01%) ⬇️
cliintegration 52.65% <34.69%> (+0.08%) ⬆️
cliunit 13.43% <0.00%> (-0.01%) ⬇️
unittests 86.29% <91.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/bench.rs 85.28% <91.83%> (+0.31%) ⬆️
src/connectors/utils/metrics.rs 92.39% <0.00%> (-2.18%) ⬇️
src/connectors/impls/kafka/producer.rs 74.36% <0.00%> (-0.73%) ⬇️
tremor-value/src/value.rs 99.08% <0.00%> (+0.09%) ⬆️
src/system/flow.rs 90.39% <0.00%> (+0.18%) ⬆️
src/pipeline.rs 86.94% <0.00%> (+0.27%) ⬆️
tremor-value/src/serde/value/de.rs 66.14% <0.00%> (+0.31%) ⬆️
src/connectors.rs 87.71% <0.00%> (+0.46%) ⬆️
src/connectors/impls/ws/server.rs 95.16% <0.00%> (+0.53%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244fb0e...9e9d0ae. Read the comment docs.

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
@mfelsche mfelsche marked this pull request as ready for review May 16, 2022 10:37
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@darach darach merged commit 55071a1 into main May 16, 2022
@darach darach deleted the blaster-fix branch May 16, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants