Skip to content

Add support for several elasticsearch auth options, TLS and more options #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 18, 2022

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented May 16, 2022

Pull request

Description

New options for elastic connector:

  • headers
  • timeout
  • auth
  • tls

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1663 (b184dd3) into main (47be0a0) will increase coverage by 0.06%.
The diff coverage is 95.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
+ Coverage   87.51%   87.58%   +0.06%     
==========================================
  Files         254      254              
  Lines       50209    50367     +158     
==========================================
+ Hits        43942    44112     +170     
+ Misses       6267     6255      -12     
Flag Coverage Δ
clicommand 14.37% <0.00%> (-0.04%) ⬇️
cliintegration 52.41% <49.16%> (-0.18%) ⬇️
cliunit 13.39% <0.00%> (-0.04%) ⬇️
unittests 86.36% <94.53%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/http/client.rs 91.95% <ø> (-0.13%) ⬇️
src/connectors/utils/tls.rs 87.06% <92.45%> (+25.95%) ⬆️
src/connectors/impls/elastic.rs 89.67% <95.06%> (+1.03%) ⬆️
src/connectors/impls/cb.rs 83.87% <100.00%> (ø)
src/connectors/impls/http/auth.rs 96.29% <100.00%> (+12.96%) ⬆️
src/connectors/impls/http/meta.rs 97.82% <100.00%> (ø)
src/connectors/impls/http/utils.rs 86.61% <100.00%> (+0.10%) ⬆️
src/errors.rs 80.85% <100.00%> (+0.07%) ⬆️
src/connectors/utils/reconnect.rs 95.02% <0.00%> (-0.83%) ⬇️
tremor-cli/src/test/before.rs 77.77% <0.00%> (-0.59%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47be0a0...b184dd3. Read the comment docs.

@mfelsche mfelsche force-pushed the elastic-auth-tls branch from 09a19d2 to fef3544 Compare May 17, 2022 12:38
@mfelsche mfelsche marked this pull request as ready for review May 17, 2022 12:43
@mfelsche mfelsche requested review from anupdhml and darach as code owners May 17, 2022 12:43
@mfelsche mfelsche force-pushed the elastic-auth-tls branch from fef3544 to 2f19057 Compare May 17, 2022 13:13
Licenser
Licenser previously approved these changes May 17, 2022
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mfelsche mfelsche force-pushed the elastic-auth-tls branch from 59e21b2 to a7c580b Compare May 17, 2022 15:39
Licenser
Licenser previously approved these changes May 17, 2022
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🇬🇵

Licenser
Licenser previously approved these changes May 17, 2022
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shall not be dismissed like this! 😂 (or at least my approval shall not be dismissed :P)

@mfelsche
Copy link
Member Author

it is not working yet anyways. For some reason on CI the elasticsearch docker image is not coming up properly with http ssl settings :( Still investigating with some heavy printf debugging

@Licenser
Copy link
Member

Oh no 😭 I'll just keep approving so you're not blocked on that.

Licenser
Licenser previously approved these changes May 17, 2022
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not today github! Approved!

mfelsche added 9 commits May 17, 2022 23:39
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
…arch

and more options.

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
and to all other tls capable connectors as well.

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
and use 127.0.0.1 instead.

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval!

@Licenser Licenser enabled auto-merge (rebase) May 17, 2022 22:23
@Licenser Licenser merged commit 17e42a9 into main May 18, 2022
@Licenser Licenser deleted the elastic-auth-tls branch May 18, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants