-
Notifications
You must be signed in to change notification settings - Fork 126
Add support for several elasticsearch auth options, TLS and more options #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
+ Coverage 87.51% 87.58% +0.06%
==========================================
Files 254 254
Lines 50209 50367 +158
==========================================
+ Hits 43942 44112 +170
+ Misses 6267 6255 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
09a19d2
to
fef3544
Compare
fef3544
to
2f19057
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
59e21b2
to
a7c580b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🇬🇵
f11a5b7
to
310ed6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shall not be dismissed like this! 😂 (or at least my approval shall not be dismissed :P)
it is not working yet anyways. For some reason on CI the elasticsearch docker image is not coming up properly with http ssl settings :( Still investigating with some heavy printf debugging |
Oh no 😭 I'll just keep approving so you're not blocked on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not today github! Approved!
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
…arch and more options. Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
and to all other tls capable connectors as well. Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
and use 127.0.0.1 instead. Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
4832162
to
f0c0b65
Compare
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval!
Pull request
Description
New options for
elastic
connector:headers
timeout
auth
tls
Related
Checklist
Performance