Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 0.1% coverage drop to handle property based tests #1666

Merged
merged 1 commit into from
May 17, 2022

Conversation

Licenser
Copy link
Member

Pull request

Description

The property based tests can be mean and stop covering a line they covered before randomly, this means we have some variation coverage. This PR should allow for that to make everyone's life easier, so I hope.

Related

  • every dependabot pr ever
  • Related Issues: I got so many issues

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

no code change

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the other sections here do, but lets give it a try. I am all in for that threshold!

@Licenser
Copy link
Member Author

neither do I :D they are the default config so I put them in as I am not sure, and couldn't find if the yaml i merged with the default or replaces it

@Licenser Licenser enabled auto-merge (rebase) May 17, 2022 07:31
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1666 (9d6765a) into main (9096491) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   87.53%   87.51%   -0.02%     
==========================================
  Files         254      254              
  Lines       50210    50210              
==========================================
- Hits        43949    43939      -10     
- Misses       6261     6271      +10     
Flag Coverage Δ
clicommand 14.40% <ø> (ø)
cliintegration 52.40% <ø> (-0.18%) ⬇️
cliunit 13.43% <ø> (ø)
unittests 86.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/unix_socket/client.rs 87.70% <0.00%> (-4.10%) ⬇️
src/connectors/utils/reconnect.rs 95.02% <0.00%> (-0.83%) ⬇️
src/connectors/source.rs 86.33% <0.00%> (-0.81%) ⬇️
src/pipeline.rs 86.94% <0.00%> (-0.28%) ⬇️
src/connectors.rs 87.09% <0.00%> (-0.16%) ⬇️
tremor-value/src/value.rs 99.08% <0.00%> (+0.09%) ⬆️
tremor-cli/src/test/before.rs 78.36% <0.00%> (+0.58%) ⬆️
src/connectors/impls/kafka/producer.rs 75.09% <0.00%> (+0.72%) ⬆️
src/connectors/utils/metrics.rs 94.56% <0.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9096491...9d6765a. Read the comment docs.

@Licenser Licenser merged commit 53be785 into main May 17, 2022
@Licenser Licenser deleted the codecov-config branch May 17, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants