Repository navigation
Allow 0.1% coverage drop to handle property based tests - #1666
Merged
Merged
Conversation
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
mfelsche
approved these changes
May 17, 2022
mfelsche
left a comment
Member
There was a problem hiding this comment.
I don't know what the other sections here do, but lets give it a try. I am all in for that threshold!
Member
Author
|
neither do I :D they are the default config so I put them in as I am not sure, and couldn't find if the yaml i merged with the default or replaces it |
Licenser
enabled auto-merge (rebase)
May 17, 2022 07:31
Codecov Report
@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
- Coverage 87.53% 87.51% -0.02%
==========================================
Files 254 254
Lines 50210 50210
==========================================
- Hits 43949 43939 -10
- Misses 6261 6271 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The property based tests can be mean and stop covering a line they covered before randomly, this means we have some variation coverage. This PR should allow for that to make everyone's life easier, so I hope.
Related
Checklist
Performance
no code change