Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exit connector into debug connectors #1668

Merged
merged 3 commits into from
May 19, 2022
Merged

Move exit connector into debug connectors #1668

merged 3 commits into from
May 19, 2022

Conversation

Licenser
Copy link
Member

Pull request

Description

Move the exit connector behind debug-connectors as it is one of the potentially destructive connectors

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

no impact

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1668 (6066086) into main (553abe3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         254      254           
  Lines       50372    50371    -1     
=======================================
  Hits        44133    44133           
+ Misses       6239     6238    -1     
Flag Coverage Δ
clicommand 14.45% <0.00%> (+<0.01%) ⬆️
cliintegration 52.40% <100.00%> (-0.16%) ⬇️
cliunit 13.39% <0.00%> (+<0.01%) ⬆️
unittests 86.38% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors.rs 87.69% <100.00%> (-0.02%) ⬇️
src/connectors/impls/unix_socket/client.rs 87.70% <0.00%> (-4.10%) ⬇️
src/connectors/utils/reconnect.rs 95.02% <0.00%> (-0.83%) ⬇️
tremor-cli/src/test/before.rs 77.77% <0.00%> (-0.59%) ⬇️
tremor-script/src/lexer.rs 92.46% <0.00%> (+0.07%) ⬆️
src/pipeline.rs 85.95% <0.00%> (+0.28%) ⬆️
src/connectors/source.rs 87.74% <0.00%> (+0.69%) ⬆️
tremor-cli/src/server.rs 65.54% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553abe3...6066086. Read the comment docs.

@Licenser Licenser force-pushed the exit-to-dbg branch 2 times, most recently from ae6251b to 8875773 Compare May 17, 2022 16:11
@Licenser Licenser enabled auto-merge (rebase) May 17, 2022 19:28
Licenser added 2 commits May 18, 2022 14:19
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser merged commit 1c36f98 into main May 19, 2022
@Licenser Licenser deleted the exit-to-dbg branch May 19, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants