Remove ack-on-drop and ack-on-dead-end. - #1670
Merged
Merged
Conversation
Those behaviours were producing edge cases where error events (from source connectors) were acked, though not handled and thus acked the original failed event. Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Codecov Report
@@ Coverage Diff @@
## main #1670 +/- ##
==========================================
- Coverage 87.60% 87.58% -0.03%
==========================================
Files 254 254
Lines 50367 50333 -34
==========================================
- Hits 44126 44085 -41
- Misses 6241 6248 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
On a quick glance I didn't see it, does this also un-ack's |
Licenser
approved these changes
May 18, 2022
Licenser
left a comment
Licenser
left a comment
Member
There was a problem hiding this comment.
🚀 yes it does I was just blind :D
mfelsche
commented
May 18, 2022
| events: vec![(port, event)], | ||
| ..EventAndInsights::default() | ||
| } | ||
| } else if event.transactional { |
Member
Author
There was a problem hiding this comment.
by removing this we do not ack on drop in scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those behaviours were producing edge cases where error events (from source connectors) were acked, though not handled and thus acked the original failed event.
Pull request
Description
Related
Checklist
Performance
The performance should be back to where it was before, before we introduced
ack-on-dropetc.