Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coveralls badge #1676

Merged
merged 1 commit into from
May 19, 2022
Merged

Remove coveralls badge #1676

merged 1 commit into from
May 19, 2022

Conversation

Licenser
Copy link
Member

Pull request

Description

We moved to codecov, coveralls is no longer reflecting the reality of our coverage.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

no impact

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@mfelsche mfelsche enabled auto-merge (rebase) May 19, 2022 11:53
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1676 (d5b3fb5) into main (1c36f98) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
- Coverage   56.15%   56.10%   -0.06%     
==========================================
  Files         243      243              
  Lines       37017    37017              
==========================================
- Hits        20787    20768      -19     
- Misses      16230    16249      +19     
Flag Coverage Δ
clicommand 14.45% <ø> (+0.01%) ⬆️
cliintegration 52.36% <ø> (-0.06%) ⬇️
cliunit 13.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/utils/metrics.rs 92.39% <0.00%> (-2.18%) ⬇️
tremor-pipeline/src/lib.rs 47.50% <0.00%> (-2.14%) ⬇️
tremor-cli/src/test/process.rs 71.34% <0.00%> (-1.22%) ⬇️
src/connectors/impls/kafka/producer.rs 71.84% <0.00%> (-1.09%) ⬇️
src/connectors/sink.rs 78.54% <0.00%> (-0.63%) ⬇️
src/pipeline.rs 82.27% <0.00%> (-0.34%) ⬇️
src/connectors/source.rs 85.36% <0.00%> (ø)
tremor-cli/src/test/before.rs 77.77% <0.00%> (ø)
src/connectors/impls/kafka/consumer.rs 73.41% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c36f98...d5b3fb5. Read the comment docs.

@mfelsche mfelsche merged commit 22fd3a8 into main May 19, 2022
@mfelsche mfelsche deleted the readme-update branch May 19, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants