Conversation
Codecov Report
@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
+ Coverage 87.59% 87.62% +0.02%
==========================================
Files 254 254
Lines 50371 50344 -27
==========================================
- Hits 44122 44113 -9
+ Misses 6249 6231 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mfelsche
previously approved these changes
May 19, 2022
Member
mfelsche
left a comment
There was a problem hiding this comment.
We should REALLY document that it loads existing patterns from a file. Couldn't find this anywhere in our docs.
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
mfelsche
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The implementation for
Clonefor the Grok extractor was buggy leading to it loosing all functionality unless the pattern was a full regular expression. This fixes it.Checklist
Performance