Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grok extractor #1677

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix grok extractor #1677

merged 1 commit into from
May 19, 2022

Conversation

Licenser
Copy link
Member

Pull request

Description

The implementation for Clone for the Grok extractor was buggy leading to it loosing all functionality unless the pattern was a full regular expression. This fixes it.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1677 (8f1293e) into main (22fd3a8) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   87.59%   87.62%   +0.02%     
==========================================
  Files         254      254              
  Lines       50371    50344      -27     
==========================================
- Hits        44122    44113       -9     
+ Misses       6249     6231      -18     
Flag Coverage Δ
clicommand 14.46% <0.00%> (+0.01%) ⬆️
cliintegration 52.54% <0.00%> (+0.05%) ⬆️
cliunit 13.40% <0.00%> (+<0.01%) ⬆️
unittests 86.40% <90.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tremor-script/src/grok.rs 99.01% <83.33%> (+1.86%) ⬆️
tremor-script/src/tilde.rs 83.98% <100.00%> (+0.82%) ⬆️
src/connectors/impls/otel/client.rs 77.22% <0.00%> (-1.00%) ⬇️
src/pipeline.rs 85.67% <0.00%> (-0.29%) ⬇️
src/system/flow.rs 90.20% <0.00%> (-0.19%) ⬇️
tremor-cli/src/test/before.rs 77.77% <0.00%> (ø)
src/connectors/source.rs 87.05% <0.00%> (+0.23%) ⬆️
src/connectors/sink.rs 87.67% <0.00%> (+0.41%) ⬆️
src/connectors/impls/kafka/producer.rs 75.09% <0.00%> (+0.72%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fd3a8...8f1293e. Read the comment docs.

mfelsche
mfelsche previously approved these changes May 19, 2022
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should REALLY document that it loads existing patterns from a file. Couldn't find this anywhere in our docs.

Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser merged commit 6b167a2 into main May 19, 2022
@Licenser Licenser deleted the fix-grok branch May 19, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants