Skip to content

Removed version from create-release#1679

Merged
Licenser merged 1 commit intotremor-rs:mainfrom
PrimalPimmy:fix
May 19, 2022
Merged

Removed version from create-release#1679
Licenser merged 1 commit intotremor-rs:mainfrom
PrimalPimmy:fix

Conversation

@PrimalPimmy
Copy link
Contributor

@PrimalPimmy PrimalPimmy commented May 19, 2022

Signed-off-by: PrimalPimmy Prashant20.pm@gmail.com

Pull request

Removed version from create-release from the step which would trigger publish-crates

Description

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@Licenser Licenser enabled auto-merge (rebase) May 19, 2022 16:49
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1679 (54fb077) into main (e350339) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
- Coverage   87.65%   87.62%   -0.03%     
==========================================
  Files         254      254              
  Lines       50344    50344              
==========================================
- Hits        44127    44115      -12     
- Misses       6217     6229      +12     
Flag Coverage Δ
clicommand 14.46% <ø> (ø)
cliintegration 52.41% <ø> (-0.21%) ⬇️
cliunit 13.40% <ø> (ø)
unittests 86.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/unix_socket/client.rs 87.70% <0.00%> (-4.10%) ⬇️
src/connectors/utils/metrics.rs 92.39% <0.00%> (-2.18%) ⬇️
src/connectors/utils/reconnect.rs 95.02% <0.00%> (-0.83%) ⬇️
src/connectors/source.rs 86.93% <0.00%> (-0.81%) ⬇️
src/connectors/impls/kafka/producer.rs 74.36% <0.00%> (-0.73%) ⬇️
tremor-script/src/ast/walkers/imut_expr.rs 88.98% <0.00%> (-0.29%) ⬇️
tremor-cli/src/test/before.rs 77.77% <0.00%> (ø)
src/connectors.rs 88.00% <0.00%> (+0.15%) ⬆️
src/pipeline.rs 86.24% <0.00%> (+0.28%) ⬆️
src/connectors/sink.rs 88.29% <0.00%> (+0.82%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e350339...54fb077. Read the comment docs.

@Licenser Licenser merged commit e9aea42 into tremor-rs:main May 19, 2022
@PrimalPimmy PrimalPimmy deleted the fix branch May 22, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants